Add version option to NoiseConditionedSFNOBuilder
#820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I highly recommend reviewing this PR commit-by-commit. "copy" commits do not modify the copied code. "move" commits only modify the way the moved code is called or imported, not the moved code itself. |
Contributor
Author
|
There are some redundant unit tests after this PR, but I'd wait to delete them until we've definitely updated to v1 / frozen the code for v0. Also this PR will have merge conflicts with the benchmarking (I'll keep the benchmark in the outer conditional_sfno dir, and have it reference the latest version / v1), but don't worry about that in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds features to version the code implementation underlying NoiseConditionedSFNOBuilder, allowing for code changes that break backwards compatibility with checkpoint loading since the previous code versions continue to be used by older checkpoints.
No functionality is changed in this PR. Diffusion-forward-prediction (not downscaling) is made to reference the v1 code, so backwards compatibility will be broken for diffusion checkpoints in a PR soon.
Changes:
Moved module builder code in
fme/ace/registry/stochastic_sfnotofme/core/models/conditional_sfnoso that it can be versionedMoved existing code in
fme/core/models/conditional_sfnoto bothv0andv1subdirectories (the implementations in this PR are identical).Added
versionoption toNoiseConditionedSFNOBuilderwhich can take optionsv0,v1, orlatest. Latest will be updated to the latest stable version (currently v0) when configuration is loaded.Tests added